-
Notifications
You must be signed in to change notification settings - Fork 2
Bulk updates from G Madariaga #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dictionary date didn't match the definition updates. SU types and linked data name types also mismatched.
The values are properly located in the templ_attr.cif file, which is where they should be modified.
This avoids cycling through the main repo while debugging the ms dic updates.
Changes to ensure definitions are internally consistent with related data names.
Make sure everything works together locally before doing a PR to main repo
cif_ms refers to multiblock and twinning dictionaries.
The cif_ms redefines the CELL category as Looped, which causes child Set categories in core to create alerts.
atom_site and cell categories needed key data names adjusted.
The import logic resulted in the non-multi-block ATOM_SITE_ANISO definition being retained, as that was the result of the first import.
A local version was used to explore fixes.
Local changes were used while developing fixes.
This was referenced Nov 7, 2025
Closed
This was referenced Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update has been provided by @gmadaria in Dec 2024 and corresponds to the version of the modulated structures dictionary that will be discussed in the next edition of Volume G. I've made some small changes but none that significantly affect meaning. The series of changes can be followed in the sequence of commits below.