Skip to content

Conversation

@jamesrhester
Copy link
Contributor

This update has been provided by @gmadaria in Dec 2024 and corresponds to the version of the modulated structures dictionary that will be discussed in the next edition of Volume G. I've made some small changes but none that significantly affect meaning. The series of changes can be followed in the sequence of commits below.

James.Hester and others added 25 commits October 20, 2025 11:24
Dictionary date didn't match the definition updates. SU types
and linked data name types also mismatched.
The values are properly located in the templ_attr.cif file, which
is where they should be modified.
This avoids cycling through the main repo while debugging the ms dic updates.
Changes to ensure definitions are internally consistent with related
data names.
Make sure everything works together locally before doing a PR to main repo
cif_ms refers to multiblock and twinning dictionaries.
The cif_ms redefines the CELL category as Looped, which causes
child Set categories in core to create alerts.
atom_site and cell categories needed key data names adjusted.
The import logic resulted in the non-multi-block ATOM_SITE_ANISO
definition being retained, as that was the result of the first
import.
A local version was used to explore fixes.
Local changes were used while developing fixes.
@jamesrhester jamesrhester merged commit f424b2f into COMCIFS:main Nov 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant